Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(push): add import types for push #66

Merged
merged 10 commits into from
Mar 8, 2022
Merged

Conversation

P0labrD
Copy link
Collaborator

@P0labrD P0labrD commented Feb 22, 2022

Based on issue #33
Fix issues #53 and #51

NOTE: This PR is still in draft as it needs more tests.

@adrienaury
Copy link
Member

adrienaury commented Feb 25, 2022

Here is a test case to validate the PR:

tables.yml

version: v1
tables:
  - name: "staff"
    keys:
      - "staff_id"
    columns:
      - name: "staff_id"
      - name: "picture"
        export: "base64"
        import: "[]byte"
lino pull source --filter staff_id=1 --table staff
{"staff_id":1,"picture":"iVBORw0KWgo="}lino pull source --filter staff_id=1 --table staff | lino push update target --table stafflino pull target --filter staff_id=1 --table staff
{"staff_id":1,"picture":"iVBORw0KWgo="}

pkg/push/model_table.go Outdated Show resolved Hide resolved
pkg/push/model_table.go Outdated Show resolved Hide resolved
pkg/push/model_table.go Outdated Show resolved Hide resolved
@adrienaury adrienaury marked this pull request as ready for review March 8, 2022 19:52
@adrienaury adrienaury merged commit e595fc9 into main Mar 8, 2022
@adrienaury adrienaury deleted the proposal-push-import-types branch March 8, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants